Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: Dashboard page ui adjustments #2261

Merged
merged 15 commits into from
Jun 26, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 25, 2020

Summary

Adjustments for the dashboard page based on stylesheet.

Mostly sizing and spacing changes are applied on Chart, PercentageBar, Wallet & Transactions list
and some minor changes (also on sizing) for app components that appear in Dashboard (e.g WalletCard SelectNetwork, WalletControls).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner June 25, 2020 18:50
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 25, 2020
@goga-m
Copy link
Contributor Author

goga-m commented Jun 25, 2020

There are generally minor changes that are included here that affect only the dashboard page, but if needed, I can break this PR into smaller ones.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2261 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2261     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       189    +165     
  Lines            142      1717   +1575     
  Branches          18       305    +287     
=============================================
+ Hits             142      1717   +1575     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91c778...ff81711. Read the comment docs.

@faustbrian faustbrian merged commit c1a49a7 into 3.0-react Jun 26, 2020
@ghost ghost deleted the refactor/dashboard-ui-adjustments branch June 26, 2020 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants