Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: get rid of jest warnings #2281

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Jun 29, 2020

Summary

Gets rid of the i18n and header search bar warnings in the unit tests. There are more warnings remaining, but those should be taken care of when refactoring the tested component.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner June 29, 2020 06:06
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #2281 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2281     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       196    +172     
  Lines            142      1837   +1695     
  Branches          18       341    +323     
=============================================
+ Hits             142      1837   +1695     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 222 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccf93e...120395f. Read the comment docs.

@faustbrian faustbrian merged commit 098ab0a into 3.0-react Jun 29, 2020
@ghost ghost deleted the refactor/jest-warnings branch June 29, 2020 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants