Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

style: comply with naming conventions #2293

Merged
merged 9 commits into from Jun 30, 2020
Merged

style: comply with naming conventions #2293

merged 9 commits into from Jun 30, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 30, 2020

  • Organise storybooks into app and domains
  • Use human naming for components instead of technical

@ghost ghost added Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2293 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2293     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       211    +187     
  Lines            142      2070   +1928     
  Branches          18       394    +376     
=============================================
+ Hits             142      2070   +1928     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d21cf...1478453. Read the comment docs.

@faustbrian faustbrian changed the title chore: comply with naming conventions style: comply with naming conventions Jun 30, 2020
@faustbrian faustbrian merged commit 1a6470e into 3.0-react Jun 30, 2020
@ghost ghost deleted the naming branch June 30, 2020 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants