Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: apply ui guidelines to wallet domain modals #2303

Merged
merged 19 commits into from
Jul 1, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 30, 2020

Summary

Add UI guidelines on app & domain components that are used in wallet domain modals.

Note: All modifications are generally minor (spacing mostly), but they affect numerous snapshots as the components affected are commonly used.

  • Modified general purpose components spacing and alignment (Modal, TransactionListItem, WalletListItem Address component, Form wrapper component, SearchBar)
  • Modified wallet domain component modals (LedgerWallet, ReceiveFunds, SignMessage, UpdateWalletName, VerifyMessage, WalletUpdate)
    All models under domain/wallet should be displayed

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2303 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2303     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       212    +188     
  Lines            142      2105   +1963     
  Branches          18       403    +385     
=============================================
+ Hits             142      2105   +1963     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
... and 239 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889a43...4d34de9. Read the comment docs.

@goga-m goga-m force-pushed the refactor/app-components-guidelines branch from 6d2de75 to add3cc8 Compare June 30, 2020 14:21
@goga-m goga-m changed the title refactor: add ui guidelines on app components refactor: apply ui guidelines to wallet domain modals Jun 30, 2020
@goga-m goga-m marked this pull request as ready for review June 30, 2020 14:34
@goga-m goga-m requested a review from faustbrian as a code owner June 30, 2020 14:34
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 30, 2020
@faustbrian faustbrian merged commit bdd436e into 3.0-react Jul 1, 2020
@ghost ghost deleted the refactor/app-components-guidelines branch July 1, 2020 02:26
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants