Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add LayoutControls component #2312

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 1, 2020

Summary

Both the dashboard as well as the plugin manager feature buttons to toggle between grid and list view. This PR adds a LayoutControls to keep things dry. The grid and list icons have been fixed/adjusted.

There are still discrepancies in the respective wallet and plugin controls component, which will be addresses in a follow up PR.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 1, 2020 00:24
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #2312 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2312     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       213    +189     
  Lines            142      2105   +1963     
  Branches          18       402    +384     
=============================================
+ Hits             142      2105   +1963     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
... and 241 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889a43...e617fbd. Read the comment docs.

@faustbrian faustbrian merged commit 6bfc62d into 3.0-react Jul 1, 2020
@ghost ghost deleted the refactor/layout-controls branch July 1, 2020 02:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants