Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: don't store env in state #2334

Closed
wants to merge 3 commits into from
Closed

refactor: don't store env in state #2334

wants to merge 3 commits into from

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 2, 2020

Summary

Removes the usage of useState / useEffect on the Welcome component (temporarily?) to stop jest from complaining.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 2, 2020 07:49
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 2, 2020
@dated dated marked this pull request as draft July 2, 2020 09:49
@dated dated closed this Jul 2, 2020
@dated dated deleted the refactor/welcome-profiles branch July 2, 2020 10:05
@ghost ghost mentioned this pull request Jul 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dated @faustbrian