Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: modal ux #2337

Merged
merged 4 commits into from
Jul 2, 2020
Merged

refactor: modal ux #2337

merged 4 commits into from
Jul 2, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 2, 2020

Summary

  • Modify modal z-index and inner content alignment
  • Disable scrolling when modal is open

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 2, 2020 10:40
@ghost ghost added the Complexity: High More than 256 lines changed. label Jul 2, 2020
@goga-m goga-m changed the title Refactor/modal ux refactor: modal ux Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #2337 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2337     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       220    +196     
  Lines            142      2213   +2071     
  Branches          18       418    +400     
=============================================
+ Hits             142      2213   +2071     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9688a...3f63e9b. Read the comment docs.

@faustbrian faustbrian merged commit a9ccc2a into 3.0-react Jul 2, 2020
@ghost ghost deleted the refactor/modal-ux branch July 2, 2020 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants