Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add navbar routing #2352

Merged
merged 111 commits into from
Jul 8, 2020
Merged

feat: add navbar routing #2352

merged 111 commits into from
Jul 8, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

Depends on #2345 and #2347 merged to be synchronized since they all are originated from the same branch and could contain duplicated implementations

  • Adds nav bar routing
  • Adds routing mapping for settings, plugins, help, exchange, and contacts
  • Add e2e to navbar routing
  • Adjust settings page to don't depend on props
  • Adjust navbar routes

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #2352 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2352     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       238    +214     
  Lines            142      2369   +2227     
  Branches          18       446    +428     
=============================================
+ Hits             142      2369   +2227     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60b284...69f7472. Read the comment docs.

@clucasalcantara clucasalcantara marked this pull request as draft July 3, 2020 02:10
@faustbrian faustbrian marked this pull request as ready for review July 8, 2020 13:34
@faustbrian faustbrian merged commit 50781a2 into 3.0-react Jul 8, 2020
@ghost ghost deleted the feat/add-navbar-routing branch July 8, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants