Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: apply header ui guidelines on pages #2355

Merged
merged 11 commits into from
Jul 3, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 3, 2020

Summary

Includes minor changes on padding and alignment on the header component along with the affected pages.

  • Refactor Header component based on UI styleguide

Affected pages using the Header:

  • Help pages
  • Vote
  • MyRegistrations
  • Contact

2020-07-03-132831_954x184_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 3, 2020 12:35
@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 3, 2020
@goga-m
Copy link
Contributor Author

goga-m commented Jul 3, 2020

@faustbrian included these several pages along with the Header component, as their snapshots were already affected, and were minor changes for the pages.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #2355 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2355     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       220    +196     
  Lines            142      2227   +2085     
  Branches          18       419    +401     
=============================================
+ Hits             142      2227   +2085     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7ccf0...1799952. Read the comment docs.

@goga-m goga-m force-pushed the refactor/page-headers-ui-guidelines branch from 715baaf to bd99a8e Compare July 3, 2020 12:58
@goga-m
Copy link
Contributor Author

goga-m commented Jul 3, 2020

@faustbrian, patching with another commit for the header line-height issue

@faustbrian faustbrian merged commit b5bfbdc into 3.0-react Jul 3, 2020
@ghost ghost deleted the refactor/page-headers-ui-guidelines branch July 3, 2020 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants