This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
refactor: apply header ui guidelines on pages #2355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@faustbrian included these several pages along with the |
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2355 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 220 +196
Lines 142 2227 +2085
Branches 18 419 +401
=============================================
+ Hits 142 2227 +2085
Continue to review full report at Codecov.
|
715baaf
to
bd99a8e
Compare
@faustbrian, patching with another commit for the header line-height issue |
faustbrian
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Includes minor changes on padding and alignment on the header component along with the affected pages.
Header
component based on UI styleguideAffected pages using the
Header
:Checklist