This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: add RouterView component to render default layout
#2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
faustbrian
reviewed
Jul 6, 2020
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
clucasalcantara
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
👍 Nicely done @luciorubeens 👯
We could jump on the tests update and stories once it's merged into the nav bar branch
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposal to add router parameters to the Navbar.
Checklist
Missing tests that should be fixed in the base branch.