Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: rename assets to networks #2390

Merged
merged 14 commits into from
Jul 7, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 7, 2020

Summary

  • Rename assets to networks to match platform-sdk naming convention.
  • Move networks lists in corresponding domain's data.ts
  • Rename existing SelectNetwork to FilterNetwork
  • Rename SelectAsset to SelectNetwork

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 7, 2020 09:06
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2390 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2390     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       226    +202     
  Lines            142      2288   +2146     
  Branches          18       438    +420     
=============================================
+ Hits             142      2288   +2146     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
... and 250 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acbe37...5352837. Read the comment docs.

@goga-m
Copy link
Contributor Author

goga-m commented Jul 7, 2020

Will make this a draft, to change the SelectAsset component name

@goga-m goga-m marked this pull request as draft July 7, 2020 09:21
@goga-m goga-m force-pushed the refactor/rename-assets-to-networks branch from 1760713 to a2ad30f Compare July 7, 2020 09:42
@goga-m goga-m force-pushed the refactor/rename-assets-to-networks branch 2 times, most recently from 32973fb to f4f3c3e Compare July 7, 2020 09:56
@goga-m goga-m marked this pull request as ready for review July 7, 2020 09:58
@faustbrian faustbrian merged commit 1f8cf99 into 3.0-react Jul 7, 2020
@ghost ghost deleted the refactor/rename-assets-to-networks branch July 7, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants