Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: add hideViewAll props to FilterNetwork component #2411

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Jul 8, 2020

Summary

The News page uses this component without showing the "all" option. See the image below:

Screenshot from 2020-07-08 17-07-13

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2411 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2411     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       239    +215     
  Lines            142      2387   +2245     
  Branches          18       450    +432     
=============================================
+ Hits             142      2387   +2245     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6c2a7...9ee196d. Read the comment docs.

@brenopolanski brenopolanski mentioned this pull request Jul 8, 2020
3 tasks
@faustbrian faustbrian merged commit 9648aa6 into 3.0-react Jul 9, 2020
@ghost ghost deleted the chore/filter-network-props branch July 9, 2020 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants