Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: fix paddings in plugin navigation #2414

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 9, 2020

Summary

Fixes the paddings of the plugin navigationbar items to match the designs. Also replaces the anchor tags with buttons so they can be activated without changing url in the storybook.

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 9, 2020 05:36
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2414 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2414     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       243    +219     
  Lines            142      2397   +2255     
  Branches          18       448    +430     
=============================================
+ Hits             142      2397   +2255     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a543c...8010bb3. Read the comment docs.

@faustbrian faustbrian merged commit 00e0e6a into 3.0-react Jul 9, 2020
@ghost ghost deleted the refactor/plugin-navbar branch July 9, 2020 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants