Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add news routing #2436

Merged
merged 4 commits into from
Jul 10, 2020
Merged

feat: add news routing #2436

merged 4 commits into from
Jul 10, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

Depends on #2413

Add news routing, fix page margins, adjust breadcrumb position

  • Add routing entrypoint
  • Add domain routing to router
  • Attach active profile
  • Update breadcrumb link

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jul 10, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2436 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2436     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       258    +234     
  Lines            142      2537   +2395     
  Branches          18       469    +451     
=============================================
+ Hits             142      2537   +2395     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd63a63...9cc5539. Read the comment docs.

@clucasalcantara clucasalcantara marked this pull request as draft July 10, 2020 14:13
@faustbrian
Copy link
Contributor

@clucasalcantara conflicts

@clucasalcantara clucasalcantara marked this pull request as ready for review July 10, 2020 16:36
@faustbrian faustbrian merged commit c0a6282 into 3.0-react Jul 10, 2020
@ghost ghost deleted the feat/add-news-routing branch July 10, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants