Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: rebuild pages using shared components #2443

Merged
merged 25 commits into from
Jul 13, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 11, 2020

Summary

Refactor all pages using shared components, Page and Section.

Domains

  • Contact
  • Dashboard
  • Exchange
  • Help
  • News
  • Offline
  • Plugin
  • Profile
  • Setting
  • Transaction
  • Vote
  • Wallet

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Status: In Progress The issue or pull request is being worked on. labels Jul 11, 2020
@dated dated changed the title Refactor/layout refactor: rebuild pages using shared components Jul 11, 2020
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #2443 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2443     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       264    +240     
  Lines            142      2597   +2455     
  Branches          18       480    +462     
=============================================
+ Hits             142      2597   +2455     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c08a3...3b751ec. Read the comment docs.

@dated dated marked this pull request as ready for review July 12, 2020 13:58
@dated dated requested a review from faustbrian as a code owner July 12, 2020 13:58
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jul 12, 2020
@faustbrian faustbrian merged commit 8a53185 into 3.0-react Jul 13, 2020
@ghost ghost deleted the refactor/layout branch July 13, 2020 15:41
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants