Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: fix registration warnings #2451

Merged
merged 6 commits into from
Jul 14, 2020
Merged

test: fix registration warnings #2451

merged 6 commits into from
Jul 14, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. Status: In Progress The issue or pull request is being worked on. labels Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #2451 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2451     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2617   +2475     
  Branches          18       487    +469     
=============================================
+ Hits             142      2617   +2475     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6a2b1...2f65d0f. Read the comment docs.

@alexbarnsley alexbarnsley marked this pull request as ready for review July 13, 2020 13:25
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jul 13, 2020
@alexbarnsley
Copy link
Member Author

@faustbrian seems to fix the warnings. It's weird, it seems to have been caused by the asFragment method

@faustbrian
Copy link
Contributor

@alexbarnsley conflicts

@faustbrian
Copy link
Contributor

@alexbarnsley syntax errors in tests

@alexbarnsley
Copy link
Member Author

Yeh will take a look properly in a bit. I quick fixed the conflicts in GH while I finished something else

@faustbrian faustbrian merged commit f6df853 into 3.0-react Jul 14, 2020
@ghost ghost deleted the test/fix-warnings branch July 14, 2020 01:46
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants