Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: update Input component #2455

Merged
merged 5 commits into from
Jul 14, 2020
Merged

fix: update Input component #2455

merged 5 commits into from
Jul 14, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Jul 13, 2020

Summary

Remove the padding styled and move it to className, allowing it to be replaced.

Before:

Screenshot from 2020-07-13 18-33-31
Screenshot from 2020-07-13 18-33-12
Screenshot from 2020-07-13 18-32-54

After:

Screenshot from 2020-07-13 22-03-38
Screenshot from 2020-07-13 22-03-30
Screenshot from 2020-07-13 22-03-22

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #2455 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2455     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2622   +2480     
  Branches          18       487    +469     
=============================================
+ Hits             142      2622   +2480     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0405733...a908125. Read the comment docs.

src/app/components/Input/InputGroup.tsx Outdated Show resolved Hide resolved
src/app/components/Input/Input.tsx Outdated Show resolved Hide resolved
@brenopolanski brenopolanski changed the title fix: realign InputAddonStart component fix: update Input component Jul 14, 2020
@faustbrian
Copy link
Contributor

@brenopolanski conflicts

@brenopolanski
Copy link
Contributor Author

done @faustbrian

@faustbrian faustbrian merged commit a8a5f7f into 3.0-react Jul 14, 2020
@ghost ghost deleted the fix/input-group branch July 14, 2020 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants