Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: integrate AddRecipient in SendTransaction #2462

Merged
merged 9 commits into from
Jul 14, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 14, 2020

Summary

Integrate AddRecipients form group in transaction-send form and page.

2020-07-14-170911_750x1107_scrot

2020-07-14-170924_1320x1220_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 14, 2020 14:11
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 14, 2020
boldninja and others added 2 commits July 14, 2020 16:33
Optimized SVG(s):
- src/app/assets/svg/questionmark.svg
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #2462 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2462     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2619   +2477     
  Branches          18       486    +468     
=============================================
+ Hits             142      2619   +2477     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a5f7f...c27b7cd. Read the comment docs.

@faustbrian faustbrian merged commit 8e8b13d into 3.0-react Jul 14, 2020
@ghost ghost deleted the refactor/send-transaction-recipients branch July 14, 2020 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants