Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: icon style conflicts #2474

Merged
merged 6 commits into from
Jul 15, 2020
Merged

fix: icon style conflicts #2474

merged 6 commits into from
Jul 15, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 15, 2020

Summary

Prevent eth SVG icon from breaking other SVG colors and styling in pages.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 15, 2020 08:41
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 15, 2020
@boldninja
chore: optimize 1 SVG(s)
a23e455 
Optimized SVG(s):
- src/app/assets/svg/currencies/eth.svg
@boldninja
chore: optimize 1 SVG(s)
ae111f7 
Optimized SVG(s):
- src/app/assets/svg/currencies/eth.svg
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #2474 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2474     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       265    +241     
  Lines            142      2634   +2492     
  Branches          18       489    +471     
=============================================
+ Hits             142      2634   +2492
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489659d...3122926. Read the comment docs.

@goga-m
Copy link
Contributor Author

goga-m commented Jul 15, 2020

@faustbrian marking it as draft, until I re-modify the fix

@goga-m goga-m marked this pull request as draft July 15, 2020 08:51
@goga-m goga-m marked this pull request as ready for review July 15, 2020 09:05
@faustbrian faustbrian merged commit 3fa334f into 3.0-react Jul 15, 2020
@ghost ghost deleted the fix/icon-style-conflicts branch July 15, 2020 17:37
@ghost ghost mentioned this pull request Jul 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goga-m @faustbrian @boldninja