Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: registration select address #2476

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 15, 2020

Summary

  • Replace native select list for Address field with SelectAddress component
  • Fix AddressField button to prevent unwanted form submissions

2020-07-15-125500_1002x917_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 15, 2020 09:59
@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #2476 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2476     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       265    +241     
  Lines            142      2632   +2490     
  Branches          18       489    +471     
=============================================
+ Hits             142      2632   +2490     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489659d...a16d904. Read the comment docs.

@faustbrian faustbrian merged commit f527f9f into 3.0-react Jul 15, 2020
@faustbrian faustbrian deleted the refactor/registration-select-address branch July 15, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants