Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: create profile routing & e2e tests #2482

Merged
merged 6 commits into from
Jul 16, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #2482 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2482     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2660   +2518     
  Branches          18       493    +475     
=============================================
+ Hits             142      2660   +2518     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c113e...bf030f1. Read the comment docs.

@alexbarnsley
Copy link
Member Author

alexbarnsley commented Jul 15, 2020

@faustbrian i have pushed a commit but it doesn't seem to be showing in the PR so don't merge yet - 34fe2ec

edit: looks like it's working now

@alexbarnsley alexbarnsley mentioned this pull request Jul 15, 2020
3 tasks
@alexbarnsley alexbarnsley changed the title test(e2e): create profile refactor: create profile routing & e2e tests Jul 15, 2020
@faustbrian faustbrian merged commit ac5e98e into 3.0-react Jul 16, 2020
@ghost ghost deleted the test/e2e-create-profile branch July 16, 2020 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants