Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjust HTTP Client to latest Platform SDK changes #2508

Merged
merged 9 commits into from
Jul 22, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 21, 2020

Summary

  • Use platform-sdk-http-node-fetch in HttpClient service
  • Upgrade platform-sdk packages to 0.9.161
  • Remove rxdb rxjs node-fetch and pouchdb-adapter-memory packages

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 21, 2020 12:51
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #2508 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2508     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2742   +2600     
  Branches          18       501    +483     
=============================================
+ Hits             142      2742   +2600     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe8151...f74f6bb. Read the comment docs.

@goga-m goga-m marked this pull request as draft July 21, 2020 13:18
@goga-m
Copy link
Contributor Author

goga-m commented Jul 21, 2020

@faustbrian included your patches from https://github.com/ArkEcosystem/desktop-wallet/tree/http-client
Thanks

@goga-m goga-m marked this pull request as ready for review July 21, 2020 15:46
@faustbrian faustbrian changed the title refactor: use sdk in HttpClient refactor: replace HTTP Client with @arkecosystem/platform-sdk-http-axios Jul 22, 2020
@faustbrian faustbrian added the Status: On Hold The issue or pull request is not being worked on for the time being. label Jul 22, 2020
@faustbrian faustbrian changed the title refactor: replace HTTP Client with @arkecosystem/platform-sdk-http-axios refactor: adjust HTTP Client to latest Platform SDK changes Jul 22, 2020
@faustbrian faustbrian merged commit 78bab92 into 3.0-react Jul 22, 2020
@ghost ghost deleted the refactor/http-client branch July 22, 2020 13:25
@ghost ghost removed the Status: On Hold The issue or pull request is not being worked on for the time being. label Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants