This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
refactor: update SelectNetwork
to use availableNetworks
#2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2509 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 269 +245
Lines 142 2857 +2715
Branches 18 513 +495
=============================================
+ Hits 142 2857 +2715
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6e25884
to
0c8721a
Compare
samharperpittam
approved these changes
Jul 21, 2020
@luciorubeens failing E2E tests after merging |
c6d5ecc
to
34fc2bb
Compare
34fc2bb
to
0739d42
Compare
faustbrian
reviewed
Jul 24, 2020
faustbrian
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SelectNetwork
component to use hooksNetworkIcon
componentNetworkData
instead of static objects.Checklist