Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: update SelectNetwork to use availableNetworks #2509

Merged
merged 9 commits into from
Jul 24, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

  • Add the network domain
  • Add a configuration file to add extra data to each network
  • Update the SelectNetwork component to use hooks
  • Add the NetworkIcon component
  • Use NetworkData instead of static objects.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #2509 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2509     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       269    +245     
  Lines            142      2857   +2715     
  Branches          18       513    +495     
=============================================
+ Hits             142      2857   +2715     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e32fcc...366744c. Read the comment docs.

@faustbrian
Copy link
Contributor

@luciorubeens failing E2E tests after merging

@luciorubeens luciorubeens force-pushed the refactor/select-network branch 3 times, most recently from c6d5ecc to 34fc2bb Compare July 23, 2020 20:45
package.json Outdated Show resolved Hide resolved
@faustbrian faustbrian merged commit 314be2b into 3.0-react Jul 24, 2020
@ghost ghost deleted the refactor/select-network branch July 24, 2020 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants