Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: modify webpack config for storybook #2531

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 27, 2020

Summary

Prevent using electron-renderer as config target in webpack config-overrides.
Fixes global is not defined error in storybook.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 27, 2020 12:41
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #2531 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2531     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       253    +229     
  Lines            142      2758   +2616     
  Branches          18       494    +476     
=============================================
+ Hits             142      2758   +2616     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d22a07...045d43e. Read the comment docs.

@faustbrian faustbrian merged commit 2fe40b4 into 3.0-react Jul 27, 2020
@ghost ghost deleted the fix/webpack-config-storybook branch July 27, 2020 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants