Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: webpack config #2541

Merged
merged 2 commits into from
Jul 28, 2020
Merged

fix: webpack config #2541

merged 2 commits into from
Jul 28, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • This adds a custom configuration for the storybook webpack to avoid the electron-renderer target removal from the base config to make storybook works since this target is needed to correctly load the node packages used into the app.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jul 28, 2020
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #2541 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2541     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       253    +229     
  Lines            142      2767   +2625     
  Branches          18       496    +478     
=============================================
+ Hits             142      2767   +2625     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f47586...2701028. Read the comment docs.

@faustbrian faustbrian merged commit ffd1429 into 3.0-react Jul 28, 2020
@ghost ghost deleted the fix/webpack-config branch July 28, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants