fix: trigger advanced mode confirmation and use defaults #2555
Conversation
ghost
added
Complexity: Medium
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2555 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 254 +230
Lines 142 2825 +2683
Branches 18 504 +486
=============================================
+ Hits 142 2825 +2683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@faustbrian i will add it |
…esktop-wallet into refactor/profile-settings
| @@ -266,7 +266,9 @@ export const General = ({ env, formConfig, onSubmit }: GeneralProps) => { | |||
| }).toString(), | |||
| })} | |||
| options={PlatformSdkChoices.passphraseLanguages} | |||
| defaultValue={activeProfile?.settings().get(ProfileSetting.Bip39Locale)} | |||
| defaultValue={ | |||
| activeProfile?.settings().get(ProfileSetting.Bip39Locale) || "english" | |||
There was a problem hiding this comment.
Those defaults shouldn't be handled here, they should be set when a profile is created.
The issue I reported with the defaults/values not being filled happens when you save your settings and reload the wallet. The values exist but the Select doesn't seem to be using them. Testing this requires to change the storage driver to indexeddb because the yarn dev command will use an in-memory storage without persistence.
There was a problem hiding this comment.
ahhh make sense now.. i saw that you added these default values here: 110939c
I will remove my default values
faustbrian
changed the title
ghost
deleted the
ghost
mentioned this pull request
Summary
Profile SettingsChecklist