This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Refactor
The pull request improves or enhances an existing implementation.
Status: In Progress
The issue or pull request is being worked on.
labels
Jul 30, 2020
@goga-m conflicts |
goga-m
force-pushed
the
refactor/use-fixture-in-tests
branch
from
July 31, 2020 19:35
2303c47
to
b132e00
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2566 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 254 +230
Lines 142 2882 +2740
Branches 18 511 +493
=============================================
+ Hits 142 2882 +2740
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ghost
deleted the
refactor/use-fixture-in-tests
branch
August 1, 2020 02:21
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Aug 1, 2020
ghost
mentioned this pull request
Aug 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use fixture data in unit tests
https://trello.com/c/XC4piEyY/188-remove-bob-stub-data
Additional helper functions:
import { useDefaultNetMocks } from 'testing-library
import { getDefaultProfileId } from 'testing-library
Checklist