Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: list transactions on dashboard #2571

Merged
merged 42 commits into from Aug 4, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Refactor transactions listing to use profile wallets
  • Refactor all transactions based components to use the typedef from Contracts inside the platform-sdk
  • Refactor all mocked transaction data to use the right body from TransactionDataType

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jul 31, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Jul 31, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2571 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2571     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       244    +220     
  Lines            142      2836   +2694     
  Branches          18       514    +496     
=============================================
+ Hits             142      2836   +2694     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad33fd...ea2ab59. Read the comment docs.

@faustbrian faustbrian force-pushed the refactor/update-dashboard-transactions-listing branch from aa7d784 to 0f85976 Compare August 4, 2020 02:07
@faustbrian faustbrian marked this pull request as ready for review August 4, 2020 04:27
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 4, 2020
@faustbrian faustbrian changed the title refactor: update dashboard transactions listing feat: list transactions on dashboard Aug 4, 2020
@faustbrian faustbrian merged commit 0129ad4 into 3.0-react Aug 4, 2020
@ghost ghost deleted the refactor/update-dashboard-transactions-listing branch August 4, 2020 04:37
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants