Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add validation and default value on UpdateWalletName #2583

Merged
merged 25 commits into from
Aug 4, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 3, 2020

Summary

  • Add Wallet name validation UX, limit to 42 characters, show required/maxlength errors.
  • Use default value from WalletDetails page.

Part of https://trello.com/c/eFH4R4wH/106-implement-wallet-labeling

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner August 3, 2020 14:45
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2583 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2583     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       248    +224     
  Lines            142      2916   +2774     
  Branches          18       526    +508     
=============================================
+ Hits             142      2916   +2774     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d3b3d...85669f5. Read the comment docs.

@goga-m goga-m force-pushed the fix/wallet-update-name-limit branch from 849810f to 1dbc317 Compare August 3, 2020 15:38
@goga-m goga-m marked this pull request as draft August 3, 2020 16:46
@goga-m
Copy link
Contributor Author

goga-m commented Aug 3, 2020

@faustbrian converting to draft to apply the maxlength validation UX

@goga-m goga-m force-pushed the fix/wallet-update-name-limit branch from e1f9e0a to 787fecb Compare August 4, 2020 06:26
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
@goga-m goga-m changed the title fix: update wallet name limit fix: add validation and default value on UpdateWalletName Aug 4, 2020
@faustbrian faustbrian changed the title fix: add validation and default value on UpdateWalletName fix: add max length validation and default value on UpdateWalletName Aug 4, 2020
@goga-m goga-m changed the title fix: add max length validation and default value on UpdateWalletName fix: add validation and default value on UpdateWalletName Aug 4, 2020
@goga-m goga-m marked this pull request as ready for review August 4, 2020 11:01
@faustbrian faustbrian merged commit 50b382c into 3.0-react Aug 4, 2020
@faustbrian faustbrian deleted the fix/wallet-update-name-limit branch August 4, 2020 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants