This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
fix: add validation and default value on UpdateWalletName
#2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2583 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 248 +224
Lines 142 2916 +2774
Branches 18 526 +508
=============================================
+ Hits 142 2916 +2774
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
849810f
to
1dbc317
Compare
@faustbrian converting to draft to apply the maxlength validation UX |
e1f9e0a
to
787fecb
Compare
faustbrian
reviewed
Aug 4, 2020
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
UpdateWalletName
UpdateWalletName
UpdateWalletName
UpdateWalletName
UpdateWalletName
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WalletDetails
page.Part of https://trello.com/c/eFH4R4wH/106-implement-wallet-labeling
Checklist