Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement route middleware #2585

Merged
merged 15 commits into from
Aug 4, 2020
Merged

Conversation

luciorubeens
Copy link
Contributor

Summary

Make useActiveProfile and useActiveWallet non-nullable.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2585 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2585     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       248    +224     
  Lines            142      2900   +2758     
  Branches          18       524    +506     
=============================================
+ Hits             142      2900   +2758     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91807f1...0a1d9db. Read the comment docs.

@luciorubeens luciorubeens marked this pull request as ready for review August 4, 2020 16:05
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 4, 2020
@faustbrian faustbrian changed the title refactor: implement route middleware feat: implement route middleware Aug 4, 2020
@faustbrian faustbrian merged commit c1dce43 into 3.0-react Aug 4, 2020
@ghost ghost deleted the refactor/route-middleware branch August 4, 2020 16:27
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants