Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add sub form wrapper component #2586

Merged
merged 2 commits into from Aug 4, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 3, 2020

Summary

Adds a SubForm component to wrap/group form fields with a different background.

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 3, 2020 18:47
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2586 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2586     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       254    +230     
  Lines            142      2864   +2722     
  Branches          18       512    +494     
=============================================
+ Hits             142      2864   +2722     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee35392...898f63f. Read the comment docs.

@faustbrian faustbrian changed the title feat: add sub form wrapper component refactor: add sub form wrapper component Aug 4, 2020
@faustbrian faustbrian merged commit bad33fd into 3.0-react Aug 4, 2020
@ghost ghost deleted the feat/sub-form branch August 4, 2020 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants