Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add application error display #2591

Merged
merged 4 commits into from
Aug 4, 2020
Merged

feat: add application error display #2591

merged 4 commits into from
Aug 4, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 4, 2020

Summary

Adds an ErrorBoundary around the main component to catch any application errors.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 4, 2020 07:15
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Aug 4, 2020
boldninja and others added 2 commits August 4, 2020 09:15
Optimized SVG(s):
- src/domains/error/images/error-banner.svg
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2591 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2591     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       246    +222     
  Lines            142      2879   +2737     
  Branches          18       519    +501     
=============================================
+ Hits             142      2879   +2737     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 269 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72895e...34d7c2f. Read the comment docs.

@dated
Copy link
Contributor Author

dated commented Aug 4, 2020

Just an aside: the application will still show the stacktrace upon error during development. This display can be dismissed which will reveal the ApplicationError component.

Steps to see it in action:

  1. yarn dev
  2. click on profile
  3. refresh application (ctrl / cmd + r)
  4. dismiss stacktrace
  5. wait a bit & hit reload

@faustbrian faustbrian merged commit 4b76009 into 3.0-react Aug 4, 2020
@ghost ghost deleted the feat/error-page branch August 4, 2020 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants