Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add CreateContact validations and tests #2597

Merged
merged 9 commits into from Aug 5, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 4, 2020

Summary

Depends on #2596

  • Add validations in Contact name field (existing contact from sdk, empty name)
  • Add coverage and e2e tests

2020-08-04-192911_579x236_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner August 4, 2020 16:31
@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2597 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2597     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       248    +224     
  Lines            142      2926   +2784     
  Branches          18       527    +509     
=============================================
+ Hits             142      2926   +2784     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b382c...649f3a7. Read the comment docs.

@faustbrian faustbrian merged commit 8b90de1 into 3.0-react Aug 5, 2020
@ghost ghost deleted the refactor/create-contact branch August 5, 2020 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants