Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: show form in SignMessage when closing modal #2599

Merged
merged 5 commits into from Aug 5, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Aug 4, 2020

Summary

  • Break the message when is very long.
  • Reset the state when close the modal.

Fixes: https://trello.com/c/e8pcMUhN/108-implement-message-signing#comment-5f292d9f40a8c362146a9989

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Aug 4, 2020
@brenopolanski brenopolanski changed the title refactor: show form in SignMessage when closing modal refactor: shows the form again in SignMessage when closing the modal Aug 4, 2020
@brenopolanski brenopolanski changed the title refactor: shows the form again in SignMessage when closing the modal refactor: show form in SignMessage when closing modal Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #2599 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2599     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       248    +224     
  Lines            142      2921   +2779     
  Branches          18       527    +509     
=============================================
+ Hits             142      2921   +2779     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b382c...90a9407. Read the comment docs.

@faustbrian faustbrian merged commit 5928e40 into 3.0-react Aug 5, 2020
@ghost ghost deleted the refactor/sign-message branch August 5, 2020 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants