Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add maxlength & validations in profile name #2612

Merged
merged 5 commits into from
Aug 6, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Aug 5, 2020

Summary

Before:

Screenshot from 2020-08-05 15-00-12

After:

Screenshot from 2020-08-05 16-46-36

Screenshot from 2020-08-05 16-23-42

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #2612 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2612     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       249    +225     
  Lines            142      2995   +2853     
  Branches          18       541    +523     
=============================================
+ Hits             142      2995   +2853     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd404d...5eae389. Read the comment docs.

@faustbrian faustbrian merged commit fd55957 into 3.0-react Aug 6, 2020
@ghost ghost deleted the fix/profile-name-length branch August 6, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants