Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement Splash screen #2617

Merged
merged 12 commits into from Aug 6, 2020
Merged

feat: implement Splash screen #2617

merged 12 commits into from Aug 6, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 6, 2020

Summary

Show splash screen on launch until initial data is loaded.
https://trello.com/c/kmWaiidX/191-implement-splash-screen

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #2617 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2617     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       251    +227     
  Lines            142      3001   +2859     
  Branches          18       544    +526     
=============================================
+ Hits             142      3001   +2859     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd404d...5549f0a. Read the comment docs.

@goga-m goga-m marked this pull request as ready for review August 6, 2020 11:23
@goga-m goga-m requested a review from faustbrian as a code owner August 6, 2020 11:23
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 6, 2020
@faustbrian faustbrian merged commit 1bb1b31 into 3.0-react Aug 6, 2020
@faustbrian faustbrian deleted the feat/splash branch August 6, 2020 12:22
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants