Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: always add wallet icons cell in wallets table row #2619

Merged
merged 6 commits into from
Aug 7, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 6, 2020

Summary

Fixes a bug in the wallets table that causes the table to be misaligned because a cell is missing. Also refactors how the icons are generated and adds tooltips.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 6, 2020 15:43
@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #2619 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2619     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       252    +228     
  Lines            142      3020   +2878     
  Branches          18       544    +526     
=============================================
+ Hits             142      3020   +2878     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7b37e...b1230ae. Read the comment docs.

@faustbrian faustbrian merged commit 773c60c into 3.0-react Aug 7, 2020
@ghost ghost deleted the fix/wallet-table branch August 7, 2020 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants