Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: align pending transactions #2627

Merged
merged 4 commits into from Aug 7, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 7, 2020

Summary

Align Pending Transaction and Transaction History columns when in empty state, in WalletDetails page.
Fixes https://trello.com/c/wStTtlud/196-align-pending-transaction-and-transaction-history-columns
2020-08-07-114553_1215x289_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner August 7, 2020 08:50
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #2627 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2627     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       252    +228     
  Lines            142      3020   +2878     
  Branches          18       544    +526     
=============================================
+ Hits             142      3020   +2878     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebcfb0...3f57564. Read the comment docs.

@faustbrian faustbrian changed the title chore: align pending transactions fix: align pending transactions Aug 7, 2020
@faustbrian faustbrian merged commit 4f86d38 into 3.0-react Aug 7, 2020
@ghost ghost deleted the chore/pending-transactions-alignment branch August 7, 2020 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants