Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: dashboard tests #2643

Merged
merged 1 commit into from
Aug 10, 2020
Merged

fix: dashboard tests #2643

merged 1 commit into from
Aug 10, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 10, 2020

Summary

Fixes:

● Dashboard › should fetch more transactions

    expect(received).toHaveLength(expected)

    Expected length: 20
    Received length: 10
    Received array:  [<tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>, <tr class="border-b border-dotted border-theme-neutral-300" data-testid="TransactionRow"><td … /><td … /><td … /><td … /><td … /><td … /><td … /><td … /></tr>]

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #2643 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2643     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       255    +231     
  Lines            142      3045   +2903     
  Branches          18       547    +529     
=============================================
+ Hits             142      3045   +2903     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81f9d8...e287cc6. Read the comment docs.

@faustbrian faustbrian merged commit 1702068 into 3.0-react Aug 10, 2020
@ghost ghost deleted the fix/dashboard-tests branch August 10, 2020 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants