Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: upgrade storybook #2656

Merged
merged 4 commits into from
Aug 14, 2020
Merged

chore: upgrade storybook #2656

merged 4 commits into from
Aug 14, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Upgrade storybook and plugins to the latest stable version (6.0.4)

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Aug 12, 2020
@ghost ghost added Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Aug 12, 2020
@clucasalcantara clucasalcantara marked this pull request as draft August 12, 2020 13:13
@clucasalcantara
Copy link
Contributor Author

it's a minor, but it would be good to use the latest storybook version since they are adding a bunch of cool and useful features, alongside perf improvements. I won't waste too much time on this upgrade since it looks like that we have a mismatch from the webpack used by the storybook and the CRA requirements, gonna focus on our prioritized tasks to the new version and later (when we have time) get back to this but if anyone finds a fast solution then 👯

Leaving this for now

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #2656 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2656     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       256    +232     
  Lines            142      3212   +3070     
  Branches          18       574    +556     
=============================================
+ Hits             142      3212   +3070     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0337dd2...d75dbc3. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review August 14, 2020 02:34
@faustbrian faustbrian merged commit 61507b1 into 3.0-react Aug 14, 2020
@ghost ghost deleted the chore/upgrade-storybook branch August 14, 2020 03:24
@faustbrian
Copy link
Contributor

@clucasalcantara made a card internally to complete the storybook 6 migration guide because things like knobs were replaced.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants