Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add the openExternal() electron to the Link component #2666

Merged
merged 5 commits into from Aug 14, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Aug 13, 2020

Summary

The <Link> component has been updated to work with the openExternal() electron.

To open an external link:

<Link to="https://explorer.ark.io" isExternal />

To navigate the app's routes:

<Link to="/profiles/create" />

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Aug 13, 2020
@brenopolanski brenopolanski marked this pull request as draft August 13, 2020 18:07
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #2666 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2666     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       256    +232     
  Lines            142      3198   +3056     
  Branches          18       574    +556     
=============================================
+ Hits             142      3198   +3056     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eb197...2f62846. Read the comment docs.

@brenopolanski brenopolanski marked this pull request as ready for review August 13, 2020 18:30
@faustbrian faustbrian merged commit b1e3dc9 into 3.0-react Aug 14, 2020
@faustbrian faustbrian deleted the refactor/link-component branch August 14, 2020 01:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants