Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add maxlength & validations in wallet name #2672

Merged
merged 2 commits into from Aug 15, 2020

Conversation

brenopolanski
Copy link
Contributor

Summary

Screenshot from 2020-08-14 21-55-57

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added the Type: Bugfix The pull request fixes an incorrect functionality or behaviour. label Aug 15, 2020
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #2672 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2672     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       257    +233     
  Lines            142      3236   +3094     
  Branches          18       582    +564     
=============================================
+ Hits             142      3236   +3094     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63a6c2...b0c9a1b. Read the comment docs.

@faustbrian faustbrian merged commit c16beb5 into 3.0-react Aug 15, 2020
@ghost ghost deleted the fix/wallet-name-length branch August 15, 2020 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants