Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: remove usage of dist imports #2690

Merged
merged 5 commits into from
Aug 19, 2020
Merged

fix: remove usage of dist imports #2690

merged 5 commits into from
Aug 19, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 19, 2020

  • Imports from dist are brittle and should be avoided.
  • Mocking dist imports through prototype is also brittle and can result in unexpected behaviours.

@ghost ghost added the Complexity: High More than 256 lines changed. label Aug 19, 2020
@faustbrian faustbrian changed the title wip fix: remove usage of dist imports Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #2690 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2690     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       259    +235     
  Lines            142      3395   +3253     
  Branches          18       604    +586     
=============================================
+ Hits             142      3395   +3253     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6248960...216fba7. Read the comment docs.

@faustbrian faustbrian merged commit 9924990 into 3.0-react Aug 19, 2020
@faustbrian faustbrian deleted the dist-usage branch August 19, 2020 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant