Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: detail modal vote #2698

Merged
merged 11 commits into from Aug 21, 2020
Merged

refactor: detail modal vote #2698

merged 11 commits into from Aug 21, 2020

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Aug 20, 2020

Summary

  • Refactor to add vote details real data from tx
  • Start basic delegates sync

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Aug 20, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2698 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2698     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       259    +235     
  Lines            142      3438   +3296     
  Branches          18       611    +593     
=============================================
+ Hits             142      3438   +3296     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdffd03...ce9ff56. Read the comment docs.

@clucasalcantara clucasalcantara marked this pull request as ready for review August 20, 2020 17:55
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 20, 2020
@faustbrian faustbrian merged commit 24cda87 into 3.0-react Aug 21, 2020
@ghost ghost deleted the refactor/detail-modal-vote branch August 21, 2020 01:11
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants