Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: additional loading states for WalletDetails page #2710

Merged
merged 19 commits into from
Aug 24, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 23, 2020

2020-08-23-204737_1230x912_scrot

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 23, 2020
@goga-m goga-m changed the title feat: add additional loading states for WalletDetails page feat: additional loading states for WalletDetails page Aug 23, 2020
@goga-m goga-m marked this pull request as ready for review August 23, 2020 18:03
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #2710 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2710     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       263    +239     
  Lines            142      3535   +3393     
  Branches          18       638    +620     
=============================================
+ Hits             142      3535   +3393     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e2733...26a311d. Read the comment docs.

Copy link
Contributor

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise, this looks good!

@faustbrian faustbrian merged commit 9677daf into 3.0-react Aug 24, 2020
@ghost ghost deleted the feat/wallet-details-loading branch August 24, 2020 15:33
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants