Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: update transaction amount to show currency #2716

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Refactor TransactionRowAmount to use total and convertedTotal.

Currently showing as "0 BTC", since wallet#syncExchangeRate needs to be called somewhere in background.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #2716 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2716     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       261    +237     
  Lines            142      3525   +3383     
  Branches          18       635    +617     
=============================================
+ Hits             142      3525   +3383     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 281 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f156d...c85bd8d. Read the comment docs.

@faustbrian faustbrian merged commit 8a37374 into 3.0-react Aug 24, 2020
@ghost ghost deleted the refactor/tx-table-amount branch August 24, 2020 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants