Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: refactor wallet e2e tests #2726

Merged
merged 10 commits into from Aug 26, 2020
Merged

test: refactor wallet e2e tests #2726

merged 10 commits into from Aug 26, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 25, 2020

Summary

Refactors the e2e tests of the wallet domain to hopefully make them a bit more stable.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 25, 2020 20:52
@ghost ghost added Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #2726 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2726     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       268    +244     
  Lines            142      3681   +3539     
  Branches          18       658    +640     
=============================================
+ Hits             142      3681   +3539     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b045321...d7d2d3f. Read the comment docs.

.testcaferc.json Outdated
@@ -4,5 +4,6 @@
"screenshots": {
"takeOnFails": true
},
"selectorTimeout": 15000
"selectorTimeout": 15000,
"assertionTimeout": 15000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦗

@faustbrian faustbrian merged commit bbd4ab4 into 3.0-react Aug 26, 2020
@ghost ghost deleted the test/wallet-e2e branch August 26, 2020 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants