Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: common base component for all cards #2742

Merged
merged 5 commits into from Aug 28, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 27, 2020

Summary

https://app.clickup.com/t/7mqr9t

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added the Complexity: Undetermined Needs specialized, in-depth review. label Aug 27, 2020
@faustbrian
Copy link
Contributor

Task linked: CU-7mqr9t Hover styles for Cards

@ghost ghost added the Status: In Progress The issue or pull request is being worked on. label Aug 27, 2020
@dated dated changed the title Refactor/cards cu 7mqr9t refactor: common base component for all cards Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #2742 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2742     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       270    +246     
  Lines            142      3830   +3688     
  Branches          18       681    +663     
=============================================
+ Hits             142      3830   +3688     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6d729...c287fdf. Read the comment docs.

@dated dated marked this pull request as ready for review August 27, 2020 21:12
@dated dated requested a review from faustbrian as a code owner August 27, 2020 21:12
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 27, 2020
@faustbrian faustbrian merged commit 1af0836 into 3.0-react Aug 28, 2020
@ghost ghost deleted the refactor/cards-CU-7mqr9t branch August 28, 2020 01:51
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants