Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement business registrations in MyRegistrations #2759

Merged
merged 28 commits into from
Sep 2, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Aug 31, 2020

Summary

Implement business entity registrations in MyRegistrations page.
Linked clickup task: https://app.clickup.com/t/7rqmqv

2020-08-31-180443_1423x1130_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #2759 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2759     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       275    +251     
  Lines            142      3934   +3792     
  Branches          18       705    +687     
=============================================
+ Hits             142      3934   +3792     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae8bfe...a15beab. Read the comment docs.

@goga-m
Copy link
Contributor Author

goga-m commented Aug 31, 2020

@faustbrian I implemented the functionality but used placeholders in the columns.

Using the ExtendedTransactionData type for the table, and wanted to ask you which would be the recommended way to pull the following data form sdk:

  • Agent
  • Business name
  • History list
  • Website link
  • MSQ
  • and Repositories list

Thanks!

@faustbrian
Copy link
Contributor

@faustbrian
Copy link
Contributor

Task linked: CU-7rqmqv Business Registrations

@faustbrian
Copy link
Contributor

faustbrian commented Aug 31, 2020

  • Agent

Agent is supposed to be Address.

  • Business name

The business name is accessible through the .name() method on the transaction.

  • History list

Yet to be implemented.

  • Website link

Yet to be implemented.

  • MSQ

Yet to be implemented.

  • Repositories list

Yet to be implemented. Will need the JSON from the IPFS file for that.

@faustbrian faustbrian marked this pull request as ready for review September 2, 2020 09:53
@faustbrian faustbrian self-requested a review as a code owner September 2, 2020 09:53
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 2, 2020
@goga-m
Copy link
Contributor Author

goga-m commented Sep 2, 2020

@faustbrian fixing a unit test for empty state. Will push in a bit

@faustbrian faustbrian merged commit 83eabf8 into 3.0-react Sep 2, 2020
@ghost ghost deleted the feat/implement-business-registrations branch September 2, 2020 12:58
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants