Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: close bottom menu when clicking on wallet #2787

Merged
merged 5 commits into from
Sep 3, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 2, 2020

Summary

https://app.clickup.com/t/7gvgvu
https://app.clickup.com/t/7pp8cc

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Sep 2, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Sep 2, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #2787 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2787     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       274    +250     
  Lines            142      3931   +3789     
  Branches          18       709    +691     
=============================================
+ Hits             142      3931   +3789     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1266330...2a8c94c. Read the comment docs.

@faustbrian faustbrian merged commit 33b2b80 into 3.0-react Sep 3, 2020
@ghost ghost deleted the refactor/bottom-menu branch September 3, 2020 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants